Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/11864 )
Change subject: IMPALA-7775: fix some lifecycle issues in statestore/session tests ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/11864/2/be/src/statestore/statestore-test.cc File be/src/statestore/statestore-test.cc: http://gerrit.cloudera.org:8080/#/c/11864/2/be/src/statestore/statestore-test.cc@40 PS2, Line 40: static ObjectPool* perm_objects > Yeah, it does - if we actually run the destructors stuff can crash while be This may be a bit subtle. Can you please add a comment about it ? -- To view, visit http://gerrit.cloudera.org:8080/11864 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b25c8b8a96bfa1183ce273b3bb4debde234dd01 Gerrit-Change-Number: 11864 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 03 Nov 2018 00:10:43 +0000 Gerrit-HasComments: Yes
