Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 )
Change subject: IMPALA-4123: Columnar decoding in Parquet ...................................................................... Patch Set 17: (2 comments) lgtm - I can also give +2 if you do not plan to wait for other people to look at the change. Note that gerrit-verify-dryrun has already started for https://gerrit.cloudera.org/#/c/11057/, which is very likely to conflict with your changes. http://gerrit.cloudera.org:8080/#/c/8319/17/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/8319/17/be/src/exec/parquet-column-readers.cc@165 PS17, Line 165: numeric_limits<int32_t>::max(); > That does seem like something we'd like to prevent, but I also think adding I am ok with the current solution - maybe the handling of max_level_ == 0 could be mentioned in the .h, as this my be different than what the reader assumes. http://gerrit.cloudera.org:8080/#/c/8319/17/be/src/util/mem-util.h File be/src/util/mem-util.h: http://gerrit.cloudera.org:8080/#/c/8319/17/be/src/util/mem-util.h@41 PS17, Line 41: // memcpy() is necessary because 'current' may not be aligned. > There's no guarantee generally that slots in tuples are aligned. The code i Thanks for the explenation! I have misunderstood this comment: https://github.com/apache/impala/blob/cd26e807f18ef5fa729d7e15d0492a1284990122/be/src/runtime/tuple.h#L56 It says that there can be padding to ensure alignment, but not that every types has to be aligned. I see this happening in IMPALA-7367 - we can win a lot with packing StringValues, but doing the same is more problematic for TimestampValues due to boost:: members. -- To view, visit http://gerrit.cloudera.org:8080/8319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c03006981c46ef0dae30602f2b73c253d9b49ef Gerrit-Change-Number: 8319 Gerrit-PatchSet: 17 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 14 Nov 2018 16:39:54 +0000 Gerrit-HasComments: Yes
