Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8319 )
Change subject: IMPALA-4123: Columnar decoding in Parquet ...................................................................... Patch Set 19: (5 comments) I did a pass out of curiosity and only had a few nits. http://gerrit.cloudera.org:8080/#/c/8319/19/be/src/exec/parquet-column-readers.cc File be/src/exec/parquet-column-readers.cc: http://gerrit.cloudera.org:8080/#/c/8319/19/be/src/exec/parquet-column-readers.cc@313 PS19, Line 313: void ReadPositions(int64_t num_to_read, int tuple_size, uint8_t* tuple_mem) RESTRICT; Is there a reason that *tuple_mem is not restricted here? http://gerrit.cloudera.org:8080/#/c/8319/19/be/src/exec/parquet-column-readers.cc@745 PS19, Line 745: return NeedsConversionInline() ? This might be more readable as an if-statement http://gerrit.cloudera.org:8080/#/c/8319/19/be/src/exec/parquet-column-readers.cc@897 PS19, Line 897: // TODO: converting timestamps after validating them can move them out of range. We Do we have a Jira for this already? http://gerrit.cloudera.org:8080/#/c/8319/19/be/src/runtime/tuple.h File be/src/runtime/tuple.h: http://gerrit.cloudera.org:8080/#/c/8319/19/be/src/runtime/tuple.h@55 PS19, Line 55: to nit: extra word http://gerrit.cloudera.org:8080/#/c/8319/19/be/src/util/mem-util.h File be/src/util/mem-util.h: http://gerrit.cloudera.org:8080/#/c/8319/19/be/src/util/mem-util.h@34 PS19, Line 34: T* current; can you initialize to nullptr (or add a brief comment why we don't)? -- To view, visit http://gerrit.cloudera.org:8080/8319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c03006981c46ef0dae30602f2b73c253d9b49ef Gerrit-Change-Number: 8319 Gerrit-PatchSet: 19 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 15 Nov 2018 17:21:37 +0000 Gerrit-HasComments: Yes
