Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 )
Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12022/1/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/12022/1/tests/shell/test_shell_commandline.py@220 PS1, Line 220: u > flake8: E501 line too long (115 > 90 characters) The error message has specific numbers, including the actual number of columns read. Should this be parameterized with actual values somehow? http://gerrit.cloudera.org:8080/#/c/12022/1/tests/shell/test_shell_commandline.py@226 PS1, Line 226: u > flake8: E501 line too long (115 > 90 characters) As above. -- To view, visit http://gerrit.cloudera.org:8080/12022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibedb11dd3d50bcdb21d508f7d21691925491946e Gerrit-Change-Number: 12022 Gerrit-PatchSet: 1 Gerrit-Owner: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Comment-Date: Sat, 01 Dec 2018 19:33:08 +0000 Gerrit-HasComments: Yes
