Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12022 )
Change subject: IMPALA-5474: Adding a trivial subquery turns error into warning ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12022/1/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/12022/1/tests/shell/test_shell_commandline.py@220 PS1, Line 220: > flake8: E501 line too long (115 > 90 characters) Done http://gerrit.cloudera.org:8080/#/c/12022/1/tests/shell/test_shell_commandline.py@220 PS1, Line 220: > The error message has specific numbers, including the actual number of colu Hi Paul, Thanks a lot for the review and comments. I reused the existing table that I believe was handcrafted to have the 11/10 mismatch. This test is also used in other places in other tests (see ./testdata/workloads/functional-query/queries/QueryTest/parquet-abort-on-error.test). So the 11/10 numbers are essentially hardcoded for this testdata. So I'm not sure whether it's worth more work to parameterize the test. But in general I agreeing that parameterizing stuff is helpful. I just updated new rev to fix the line length, and I also added some comments to the test. Thanks. -- To view, visit http://gerrit.cloudera.org:8080/12022 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibedb11dd3d50bcdb21d508f7d21691925491946e Gerrit-Change-Number: 12022 Gerrit-PatchSet: 2 Gerrit-Owner: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <par0...@yahoo.com> Gerrit-Reviewer: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Comment-Date: Sun, 02 Dec 2018 18:42:42 +0000 Gerrit-HasComments: Yes
