Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12024 )
Change subject: IMPALA-7625: test_web_pages.py backend tests are failing ...................................................................... Patch Set 2: (8 comments) http://gerrit.cloudera.org:8080/#/c/12024/2/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/12024/2/tests/common/impala_test_suite.py@838 PS2, Line 838: assert expected_state == actual_state > How about raising Timeout() from common/errors.py, or creating your own exc Done. Using common.errors.Timeout http://gerrit.cloudera.org:8080/#/c/12024/2/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12024/2/tests/webserver/test_web_pages.py@269 PS2, Line 269: wait_for_state > I feel that "expected_state" would be clearer. Done http://gerrit.cloudera.org:8080/#/c/12024/2/tests/webserver/test_web_pages.py@295 PS2, Line 295: "create table {0}.foo as {1}".format(unique_database, sleep_query)]: > I think this would look cleaner if you define the second query outside of t Done http://gerrit.cloudera.org:8080/#/c/12024/2/tests/webserver/test_web_pages.py@296 PS2, Line 296: response_json =\ > nit: wrap after the opening ( Done http://gerrit.cloudera.org:8080/#/c/12024/2/tests/webserver/test_web_pages.py@305 PS2, Line 305: for key in ['cpu_user_s', 'rpc_latency', 'num_remaining_instances', > Maybe define those as expected_backend_states at the top of the function. T Done http://gerrit.cloudera.org:8080/#/c/12024/2/tests/webserver/test_web_pages.py@313 PS2, Line 313: response_json =\ > nit: wrap after the opening ( instead. Done http://gerrit.cloudera.org:8080/#/c/12024/2/tests/webserver/test_web_pages.py@318 PS2, Line 318: def test_backend_instances(self, unique_database, query_options=None): > Please check the comments on the previous function for applicability here. Done http://gerrit.cloudera.org:8080/#/c/12024/2/tests/webserver/test_web_pages.py@354 PS2, Line 354: dict > Make this a named parameter to make the core more robust against future cha Done -- To view, visit http://gerrit.cloudera.org:8080/12024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2092afe1bfaec30cd3e7b0040f06865e43fe62fb Gerrit-Change-Number: 12024 Gerrit-PatchSet: 2 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Dec 2018 16:41:42 +0000 Gerrit-HasComments: Yes
