Sahil Takiar has posted comments on this change. ( http://gerrit.cloudera.org:8080/12024 )
Change subject: IMPALA-7625: test_web_pages.py backend tests are failing ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12024/4/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/12024/4/tests/common/impala_test_suite.py@837 PS4, Line 837: while (actual_state != expected_state and time.time() - start_time < timeout): > nit: you don't need parentheses around the while condition Done http://gerrit.cloudera.org:8080/#/c/12024/4/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: http://gerrit.cloudera.org:8080/#/c/12024/4/tests/webserver/test_web_pages.py@271 PS4, Line 271: cancels the query.""" > Should we mention that this function now optionally waits for a particular Done -- To view, visit http://gerrit.cloudera.org:8080/12024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2092afe1bfaec30cd3e7b0040f06865e43fe62fb Gerrit-Change-Number: 12024 Gerrit-PatchSet: 4 Gerrit-Owner: Sahil Takiar <stak...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sahil Takiar <stak...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Jan 2019 18:06:55 +0000 Gerrit-HasComments: Yes