Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12213 )
Change subject: IMPALA-7929. Impala query on HBASE table failing with InternalException. ...................................................................... Patch Set 1: (4 comments) Joe beat me to it! I think my comments aren't totally redundant. http://gerrit.cloudera.org:8080/#/c/12213/1/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/12213/1/common/thrift/PlanNodes.thrift@291 PS1, Line 291: 3: optional i32 op_ordinal : 4: optional string filter_constant > Do these need to be optional? Is filter_constant ever null? Same question http://gerrit.cloudera.org:8080/#/c/12213/1/tests/query_test/test_hbase_queries.py File tests/query_test/test_hbase_queries.py: http://gerrit.cloudera.org:8080/#/c/12213/1/tests/query_test/test_hbase_queries.py@77 PS1, Line 77: table_name = "%s.hbase_col_name_testkeyb" % unique_database We generally prefer using {0}, {1} and .format() over the % operator in new code, it would be good to convert over. http://gerrit.cloudera.org:8080/#/c/12213/1/tests/query_test/test_hbase_queries.py@89 PS1, Line 89: self.client.execute("select * from %s where k != 'row1'" % table_name) We should validate that the results are correct just to make sure that we haven't traded one bug for another. The best way to do this is to create a .test file with the query and expected results. http://gerrit.cloudera.org:8080/#/c/12213/1/tests/query_test/test_hbase_queries.py@91 PS1, Line 91: self.run_stmt_in_hive(del_table) This is not needed - the unique_database handles deleting the database -- To view, visit http://gerrit.cloudera.org:8080/12213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I378c2249604481067b5b1c3a3bbb28c30ad4d751 Gerrit-Change-Number: 12213 Gerrit-PatchSet: 1 Gerrit-Owner: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Comment-Date: Thu, 10 Jan 2019 21:46:34 +0000 Gerrit-HasComments: Yes
