Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12213 )
Change subject: IMPALA-7929. Impala query on HBASE table failing with InternalException. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12213/1/common/thrift/PlanNodes.thrift File common/thrift/PlanNodes.thrift: http://gerrit.cloudera.org:8080/#/c/12213/1/common/thrift/PlanNodes.thrift@287 PS1, Line 287: 2: optional string qualifier > Thanks Joe, I thought once we make something optional in the middle, the on Ok, so a null in the Java side becomes an empty string in C++. Then when we pass it back to Java via CreateByteArray, it becomes HConstants.EMPTY_START_ROW, which is HConstants.EMPTY_BYTE_ARRAY. It turns out that inside org.apache.hadoop.hbase.client.Scan.addColumn(), it converts qualifier == null to HConstants.EMPTY_BYTE_ARARY. So, that sounds right. This line bugs me: https://github.com/apache/impala/blob/1c94450ca92606fb6b708de2ea07445cc6610dbf/be/src/exec/hbase-table-scanner.cc#L328 -- To view, visit http://gerrit.cloudera.org:8080/12213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I378c2249604481067b5b1c3a3bbb28c30ad4d751 Gerrit-Change-Number: 12213 Gerrit-PatchSet: 1 Gerrit-Owner: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Comment-Date: Fri, 11 Jan 2019 23:48:42 +0000 Gerrit-HasComments: Yes
