Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 )
Change subject: IMPALA-7979: Enhance decoders to support value-skipping ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12172/2/be/src/util/rle-encoding.h File be/src/util/rle-encoding.h: http://gerrit.cloudera.org:8080/#/c/12172/2/be/src/util/rle-encoding.h@702 PS2, Line 702: num_remaining -= num_literals_to_skip - num_to_skip; > Shouldn't this just be num_remaining -= num_to_skip? Do we have a test? Oops, turned out my test arrays were too small, so we never exercised this path. After this incident I measured code coverage with Gcov and added new tests. Now all lines should be covered by the tests. -- To view, visit http://gerrit.cloudera.org:8080/12172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib848f1bd71735fe84e8064daf700417b32589f57 Gerrit-Change-Number: 12172 Gerrit-PatchSet: 2 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Jan 2019 14:47:36 +0000 Gerrit-HasComments: Yes
