Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12172 )
Change subject: IMPALA-7979: Enhance decoders to support value-skipping ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/12172/3/be/src/util/bit-stream-utils-test.cc File be/src/util/bit-stream-utils-test.cc: http://gerrit.cloudera.org:8080/#/c/12172/3/be/src/util/bit-stream-utils-test.cc@91 PS3, Line 91: void TestSkipping(const uint8_t* buffer, const int len, const int bit_width, Might be worth adding a brief comment explaining the testing strategy, e.g. "Tests SkipBatch() by comparing the results of a reader with skipping against a reader that doesn't skip" http://gerrit.cloudera.org:8080/#/c/12172/3/be/src/util/rle-test.cc File be/src/util/rle-test.cc: http://gerrit.cloudera.org:8080/#/c/12172/3/be/src/util/rle-test.cc@301 PS3, Line 301: ValidateRleSkip(seq, bit_width, min_run_length, 0, 7); > optional: these random looking numbers suggests to me that it would make se Yeah, I like randomised tests. I don't think this code is so complex that it's an absolute must-have but it seems worth the effort. -- To view, visit http://gerrit.cloudera.org:8080/12172 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib848f1bd71735fe84e8064daf700417b32589f57 Gerrit-Change-Number: 12172 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Jan 2019 21:05:37 +0000 Gerrit-HasComments: Yes
