Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12213 )
Change subject: IMPALA-7929. Impala query on HBASE table failing with InternalException. ...................................................................... Patch Set 2: > > (1 comment) > > HI Joe, thanks for the very good observation. I did some checking, > indeed the code you referred to skip this kind of entries. However, > the fact that the tests I added get the right results. Need to > understand why. Thanks. I figured out that for column mapped to hbase key, the filter is added here https://github.com/apache/impala/blob/1c94450ca92606fb6b708de2ea07445cc6610dbf/be/src/exec/hbase-table-scanner.cc#L394 I think this could explain why it still works for my unit test even though the filters are skipped in the code blocks before this one. -- To view, visit http://gerrit.cloudera.org:8080/12213 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I378c2249604481067b5b1c3a3bbb28c30ad4d751 Gerrit-Change-Number: 12213 Gerrit-PatchSet: 2 Gerrit-Owner: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Yongjun Zhang <yjzhan...@apache.org> Gerrit-Comment-Date: Mon, 14 Jan 2019 22:44:26 +0000 Gerrit-HasComments: No