Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12238 )
Change subject: IMPALA-8090: race when reusing ScanRange in test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12238/2/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/12238/2/be/src/runtime/io/scan-range.cc@240 PS2, Line 240: file_reader_->Close(); > This bug existed earlier as well, but FileReader::Close() is not idempotent Ah good point. The Close() call in CancelInternal() actually means its unsafe to reuse scan ranges that hit an error. I think instead of trying to fix the whole issue I'll document it - product code doesn't reuse scan ranges in this way. -- To view, visit http://gerrit.cloudera.org:8080/12238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3122e5b2efea60ffe82d780930301d5be108876b Gerrit-Change-Number: 12238 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 22 Jan 2019 19:59:44 +0000 Gerrit-HasComments: Yes
