Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12238 )
Change subject: IMPALA-8090: race when reusing ScanRange in test ...................................................................... Patch Set 3: Code-Review+2 (2 comments) This makes sense to me. http://gerrit.cloudera.org:8080/#/c/12238/3/be/src/runtime/io/scan-range.cc File be/src/runtime/io/scan-range.cc: http://gerrit.cloudera.org:8080/#/c/12238/3/be/src/runtime/io/scan-range.cc@242 PS3, Line 242: then Nit: drop 'then' http://gerrit.cloudera.org:8080/#/c/12238/3/be/src/runtime/io/scan-range.cc@243 PS3, Line 243: client Nit: Duplicate 'client' -- To view, visit http://gerrit.cloudera.org:8080/12238 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3122e5b2efea60ffe82d780930301d5be108876b Gerrit-Change-Number: 12238 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Thu, 24 Jan 2019 19:26:17 +0000 Gerrit-HasComments: Yes
