Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12249 )
Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default ...................................................................... Patch Set 1: Code-Review+1 (2 comments) Given the subtlety of this change, it may make sense to have a second reviewer take a look too. http://gerrit.cloudera.org:8080/#/c/12249/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12249/1//COMMIT_MSG@16 PS1, Line 16: Ran exhaustive tests with a thread pool of 10. Did you run with Kerberos enabled ? It may make sense to run stress test in a secure cluster with FLAGS_accepted_cnxn_setup_thread_pool_size and FLAGS_fe_service_threads set to some values such as 128. http://gerrit.cloudera.org:8080/#/c/12249/1/be/src/transport/TSaslServerTransport.cpp File be/src/transport/TSaslServerTransport.cpp: http://gerrit.cloudera.org:8080/#/c/12249/1/be/src/transport/TSaslServerTransport.cpp@179 PS1, Line 179: lock_guard<mutex> l(transportMap_mutex_); Does it make sense to DCHECK(transportMap_.find(trans) == transportMap_.end()); here ? -- To view, visit http://gerrit.cloudera.org:8080/12249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I053120d4c3153ddbe5261acd28388be6cd191908 Gerrit-Change-Number: 12249 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Jan 2019 00:30:51 +0000 Gerrit-HasComments: Yes
