Hello Michael Ho, Thomas Marshall, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12249 to look at the new patch set (#2). Change subject: IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default ...................................................................... IMPALA-7565: Set TAcceptQueueServer connection_setup_pool to be multi-threaded by default Bumping up the thread count for the threads that process the post-accept, pre-setup connection queue to 2 in order to minimize the chances of a single client holding up others if the thread gets stuck in that step. This patch also un-hides the advanced startup flag 'accepted_cnxn_setup_thread_pool_size'. Testing: - Ran exhaustive tests with a thread pool of 10. - Scanned manually through the code and parts of thrift lib to make sure the APIs are used in a thread safe manner. - Rapidly executed openssl connect-disconnect on the impalad's hs2 server port on a thread sanitizer build. No data races were flagged by the thread sanitizer. - Ran a stress test on an 8 node secure cluster with 100 concurrent streams executing the tpch workload with a scale of 5g and a connection_setup_pool of 100. Change-Id: I053120d4c3153ddbe5261acd28388be6cd191908 --- M be/src/rpc/TAcceptQueueServer.cpp M be/src/transport/TSaslServerTransport.cpp 2 files changed, 5 insertions(+), 9 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/12249/2 -- To view, visit http://gerrit.cloudera.org:8080/12249 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I053120d4c3153ddbe5261acd28388be6cd191908 Gerrit-Change-Number: 12249 Gerrit-PatchSet: 2 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com>