Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12427 )
Change subject: IMPALA-8039: Incorrect selectivity estimate for not-equals predicate ...................................................................... Patch Set 2: (3 comments) Patch makes sense to me in general. http://gerrit.cloudera.org:8080/#/c/12427/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12427/2//COMMIT_MSG@7 PS2, Line 7: IMPALA-8039 IMPALA-7560 is another jira for this. http://gerrit.cloudera.org:8080/#/c/12427/2/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java File fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java: http://gerrit.cloudera.org:8080/#/c/12427/2/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@219 PS2, Line 219: } else { : // selectivity_ = 0.1; : } I think these else branches are also taken for complex predicates (since distinctValues = 0 in L212). That looks risky, was that intentional? http://gerrit.cloudera.org:8080/#/c/12427/2/testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test File testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test: http://gerrit.cloudera.org:8080/#/c/12427/2/testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test@1178 PS2, Line 1178: NOT p_type LIKE 'MEDIUM POLISHED%', p_brand != 'Brand#45' Should we use consistent ordering (sort?) -- To view, visit http://gerrit.cloudera.org:8080/12427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f6013c9ef95a89d55d8b25f0b5433c81582a62f Gerrit-Change-Number: 12427 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Feb 2019 00:21:10 +0000 Gerrit-HasComments: Yes
