Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12427 )
Change subject: IMPALA-7560: Improve selectivity estimate for != ...................................................................... Patch Set 3: Code-Review+2 (3 comments) Couple of nits. http://gerrit.cloudera.org:8080/#/c/12427/3/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java File fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java: http://gerrit.cloudera.org:8080/#/c/12427/3/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@216 PS3, Line 216: switch (op_) { nit: switch case indentation seems off. switch (condition) { case foo: } http://gerrit.cloudera.org:8080/#/c/12427/3/fe/src/main/java/org/apache/impala/analysis/BinaryPredicate.java@227 PS3, Line 227: selectivity_ = 1.0 - 1.0 / distinctValues; nit: I think you could refactor the whole thing like before to make the intent clear, if (singleCol && distinctVals > 0) { swtich () { } } http://gerrit.cloudera.org:8080/#/c/12427/2/testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test File testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test: http://gerrit.cloudera.org:8080/#/c/12427/2/testdata/workloads/functional-planner/queries/PlannerTest/tpch-kudu.test@1178 PS2, Line 1178: NOT p_type LIKE 'MEDIUM POLISHED%', p_brand != 'Brand#45' > Looks like PlanNode.orderConjunctsByCost() sorts by some combination of sel Ah right. thanks -- To view, visit http://gerrit.cloudera.org:8080/12427 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8f6013c9ef95a89d55d8b25f0b5433c81582a62f Gerrit-Change-Number: 12427 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Rogers <prog...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Paul Rogers <prog...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Feb 2019 18:43:56 +0000 Gerrit-HasComments: Yes
