hector.aco...@cloudera.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/12420 )
Change subject: Add support for compiling using OpenSSL 1.1 ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12420/1/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/12420/1/be/src/util/openssl-util.cc@76 PS1, Line 76: #else : return TLS1_2_VERSION; : #endif : } > Why this change here ? Is there anything wrong with keeping the SSLv23_meth SSLv23_method() still works fine, but the returned object is now opaque. i.e. (cdh) ? cdh git:(hacosta-ubuntu) ? cat hacosta.cc #include <openssl/ssl.h> #include <stdio.h> int MaxSupportedTlsVersion() { return SSLv23_method()->version; } int main() { printf("%d\n", MaxSupportedTlsVersion()); } (cdh) ? cdh git:(hacosta-ubuntu) ? docker run -it -v$(pwd):/mnt -w /mnt impala-toolchain-ubuntu1804 bash -c "gcc hacosta.cc -lssl && ./a.out" hacosta.cc: In function 'int MaxSupportedTlsVersion()': hacosta.cc:5:25: error: invalid use of incomplete type 'const SSL_METHOD {aka const struct ssl_method_st}' return SSLv23_method()->version; -- To view, visit http://gerrit.cloudera.org:8080/12420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaccf1b2dedf0d957a2665df8f9afca4139754264 Gerrit-Change-Number: 12420 Gerrit-PatchSet: 2 Gerrit-Owner: hector.aco...@cloudera.com <hector.aco...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: hector.aco...@cloudera.com <hector.aco...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Feb 2019 00:34:08 +0000 Gerrit-HasComments: Yes
