Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/12420 )
Change subject: Add support for compiling using OpenSSL 1.1 ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/12420/1/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/12420/1/be/src/util/openssl-util.cc@76 PS1, Line 76: #else : // OpenSSL 1.1+ doesn't let us detect the supported TLS version at runtime. Assume : // that the OpenSSL library we're linked against supports only up to TLS1.2 : > I guess OpenSSL is expecting that callers will pass in the version they wan Fair enough. Agree that if we compile against OpenSSL 1.1, we would expect the OpenSSL version which can be linked against Impala at runtime should support TLS 1.2. -- To view, visit http://gerrit.cloudera.org:8080/12420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iaccf1b2dedf0d957a2665df8f9afca4139754264 Gerrit-Change-Number: 12420 Gerrit-PatchSet: 3 Gerrit-Owner: hector.aco...@cloudera.com <hector.aco...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: hector.aco...@cloudera.com <hector.aco...@cloudera.com> Gerrit-Comment-Date: Tue, 12 Feb 2019 18:33:00 +0000 Gerrit-HasComments: Yes