Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12452 )
Change subject: IMPALA-8186: script to configure docker network ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh File docker/configure_test_network.sh: http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@43 PS2, Line 43: Create creating Nit: extra word http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@44 PS2, Line 44: impala-cluster I think this should be $NETWORK_NAME ? http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@50 PS2, Line 50: echo "export INTERNAL_LISTEN_HOST=${GATEWAY}" >> bin/impala-config-local.sh : echo "export DEFAULT_FS=hdfs://\${INTERNAL_LISTEN_HOST}:20500" \ : >> bin/impala-config-local.sh Nit: Can we also add an accompanying comment to bin/impala-config-local.sh before the config lines. Something like: echo "# Configuration to use docker network ${NETWORK_NAME}" >> /bin/impala-config-local.sh -- To view, visit http://gerrit.cloudera.org:8080/12452 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d Gerrit-Change-Number: 12452 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 12 Feb 2019 17:34:47 +0000 Gerrit-HasComments: Yes
