Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12452 )

Change subject: IMPALA-8186: script to configure docker network
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh
File docker/configure_test_network.sh:

http://gerrit.cloudera.org:8080/#/c/12452/2/docker/configure_test_network.sh@50
PS2, Line 50: echo "export INTERNAL_LISTEN_HOST=${GATEWAY}" >> 
bin/impala-config-local.sh
> There's some sort of "--bip" flag that I've used to make Docker not knock m
Locally I've passed in --gateway and --subnet to "docker network create" to 
force it to use particular IPs. I'm going to think if just exposing those flags 
is the right way to approach this or if there's a nicer way to handle it.



--
To view, visit http://gerrit.cloudera.org:8080/12452
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb4854aa951bcad7087a9653845b22ffd862057d
Gerrit-Change-Number: 12452
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Philip Zeyliger <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Tue, 12 Feb 2019 21:02:35 +0000
Gerrit-HasComments: Yes

Reply via email to