Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 )
Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/12601/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/12601/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@328 PS1, Line 328: // No need to change the EventProcessor state to error since we want the > Can you make the error log state that the metastore might be unavailable, a Done http://gerrit.cloudera.org:8080/#/c/12601/3/fe/src/test/java/org/apache/impala/catalog/events/HMSFetchNotificationsEventProcessorForTests.java File fe/src/test/java/org/apache/impala/catalog/events/HMSFetchNotificationsEventProcessorForTests.java: http://gerrit.cloudera.org:8080/#/c/12601/3/fe/src/test/java/org/apache/impala/catalog/events/HMSFetchNotificationsEventProcessorForTests.java@25 PS3, Line 25: > java doc explaining what it does would be great Done http://gerrit.cloudera.org:8080/#/c/12601/3/fe/src/test/java/org/apache/impala/catalog/events/HMSFetchNotificationsEventProcessorForTests.java@40 PS3, Line 40: throws MetastoreNotificationFetchException { > format to inline with } Done http://gerrit.cloudera.org:8080/#/c/12601/3/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/12601/3/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@531 PS3, Line 531: catalog_, eventsProcessor_.getCurrentEventId(), 2L); > Since this is used only this method, you don't need to declare the variable Done -- To view, visit http://gerrit.cloudera.org:8080/12601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I570a52462e6d3b634b2c227dfcb98e20ad2a0023 Gerrit-Change-Number: 12601 Gerrit-PatchSet: 4 Gerrit-Owner: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Feb 2019 23:54:13 +0000 Gerrit-HasComments: Yes
