Anurag Mantripragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12601 )
Change subject: IMPALA-8240: Event processor should keep trying when metastore is unavailable. ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12601/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/12601/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@556 PS5, Line 556: // Roughly half of the time an exception is thrown. Make sure the event processor : // is still active. : for(int i = 0 ; i < 11 ; i++) { : fetchProcessor.processEvents(); : assertEquals(EventProcessorStatus.ACTIVE, fetchProcessor.getStatus()); : } > Looks like this can even pass when no exceptions are thrown. I think we sho I'm sorry, not sure what you mean here. The test class makes sure that exceptions are thrown roughly half of the times this method is called..This is actually an overkill. I want to test the status has not changed to ERROR after exceptions. This was the behavior before the change - Even a single exception would change the status to ERROR which would prevent the EventProcessor to run the next time. -- To view, visit http://gerrit.cloudera.org:8080/12601 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I570a52462e6d3b634b2c227dfcb98e20ad2a0023 Gerrit-Change-Number: 12601 Gerrit-PatchSet: 5 Gerrit-Owner: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Anurag Mantripragada <anuragmantr...@gmail.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Feb 2019 00:20:38 +0000 Gerrit-HasComments: Yes
