Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12637 )
Change subject: IMPALA-7916: Remove support for authorization policy file flag ...................................................................... Patch Set 3: (12 comments) http://gerrit.cloudera.org:8080/#/c/12637/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/12637/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@24 PS3, Line 24: import java.util.*; nit: don't use wildcard imports. http://gerrit.cloudera.org:8080/#/c/12637/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@69 PS3, Line 69: // Policy file has defined current user and 'test_user' have: : // ALL permission on 'tpch' database and 'newdb' database : // ALL permission on 'functional_seq_snap' database : // SELECT permissions on all tables in 'tpcds' database : // SELECT, REFRESH, DROP permissions on 'functional.alltypesagg' : // ALTER permissions on 'functional.alltypeserror' : // SELECT permissions on 'functional.complex_view' : // SELECT, REFRESH permissions on 'functional.view_view' : // ALTER, DROP permissions on 'functional.alltypes_view' : // SELECT permissions on columns ('id', 'int_col', and 'year') on : // 'functional.alltypessmall' (no SELECT permissions on 'functional.alltypessmall') : // SELECT permissions on columns ('id', 'int_struct_col', 'struct_array_col', : // 'int_map_col') on 'functional.allcomplextypes' (no SELECT permissions on : // 'functional.allcomplextypes') : // ALL permissions on 'functional_parquet.allcomplextypes' : // SELECT permissions on all the columns of 'functional.alltypestiny' (no SELECT : // permissions on table 'functional.alltypestiny') : // INSERT permissions on 'functional.alltypes' (no SELECT permissions) : // INSERT permissions on all tables in 'functional_parquet' database : // No permissions on database 'functional_rc' : // Only column level permissions in 'functional_avro': : // SELECT permissions on columns ('id') on 'functional_avro.alltypessmall' : // REFRESH, INSERT, CREATE, ALTER, DROP permissions on 'functional_text_lzo' database all these comments may no longer be relevant. http://gerrit.cloudera.org:8080/#/c/12637/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@792 PS3, Line 792: nit: indentation off http://gerrit.cloudera.org:8080/#/c/12637/3/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: http://gerrit.cloudera.org:8080/#/c/12637/3/testdata/bin/create-load-data.sh@a299 PS3, Line 299: authz-policy.ini.template file needs to be removed. http://gerrit.cloudera.org:8080/#/c/12637/3/tests/authorization/test_authorization.py File tests/authorization/test_authorization.py: http://gerrit.cloudera.org:8080/#/c/12637/3/tests/authorization/test_authorization.py@32 PS3, Line 32: from getpass import getuser This is nice! Thanks for making it more readable. http://gerrit.cloudera.org:8080/#/c/12637/3/tests/authorization/test_authorization.py@67 PS3, Line 67: verify=True add comment for verify is true and exception will be raised when there was an exception in HS2. http://gerrit.cloudera.org:8080/#/c/12637/3/tests/authorization/test_authorization.py@73 PS3, Line 73: if verify: : TestHS2.check_response(result) : return result nit: can be simplified to return TestHS2.check_response(result) if verify else result http://gerrit.cloudera.org:8080/#/c/12637/3/tests/authorization/test_authorization.py@77 PS3, Line 77: verify=True add comment as well. http://gerrit.cloudera.org:8080/#/c/12637/3/tests/authorization/test_authorization.py@83 PS3, Line 83: if verify: : TestHS2.check_response(resp) : return resp nit; same as above http://gerrit.cloudera.org:8080/#/c/12637/3/tests/authorization/test_authorization.py@122 PS3, Line 122: unique_db = "test_access_runtime_profile_" + get_random_id(5) Can you create a test fixture for unique_name? Sounds like it'll be a useful thing to have. http://gerrit.cloudera.org:8080/#/c/12637/3/tests/authorization/test_authorization.py@167 PS3, Line 167: nit: indentation off http://gerrit.cloudera.org:8080/#/c/12637/3/tests/authorization/test_authorization.py@253 PS3, Line 253: \ nit: i don't think it's necessary -- To view, visit http://gerrit.cloudera.org:8080/12637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a52c2d5d35f58fbff8c088fb0bf30169625ebd Gerrit-Change-Number: 12637 Gerrit-PatchSet: 3 Gerrit-Owner: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 28 Feb 2019 21:13:53 +0000 Gerrit-HasComments: Yes
