Austin Nobis has posted comments on this change. ( http://gerrit.cloudera.org:8080/12637 )
Change subject: IMPALA-7916: Remove support for authorization policy file ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/12637/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12637/5//COMMIT_MSG@7 PS5, Line 7: flag : > nit: remove Done http://gerrit.cloudera.org:8080/#/c/12637/5//COMMIT_MSG@9 PS5, Line 9: This patch removes support for the flag --authorization_policy_file. : The flag can still be passed to the backend but a warning message will : be logged in the frontend that the policy file has no effect on : authorization. > mention that the tests that rely on sentry authorization policy file have b Done http://gerrit.cloudera.org:8080/#/c/12637/5/fe/src/main/java/org/apache/impala/service/JniFrontend.java File fe/src/main/java/org/apache/impala/service/JniFrontend.java: http://gerrit.cloudera.org:8080/#/c/12637/5/fe/src/main/java/org/apache/impala/service/JniFrontend.java@711 PS5, Line 711: if (BackendConfig.INSTANCE.isAuthorizationFileSet()) { : LOG.warn("authorization_policy_file flag is no longer supported. The " + : "flag is being ignored."); : } > We should handle it in the backend instead. See: https://github.com/apache/ Done -- To view, visit http://gerrit.cloudera.org:8080/12637 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a52c2d5d35f58fbff8c088fb0bf30169625ebd Gerrit-Change-Number: 12637 Gerrit-PatchSet: 5 Gerrit-Owner: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Mon, 04 Mar 2019 18:40:40 +0000 Gerrit-HasComments: Yes
