Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 )
Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script ...................................................................... Patch Set 1: (1 comment) Let me know what you think. If we go with always using DEBIAN_FRONTEND=noninteractive, then please note that in the commit message. http://gerrit.cloudera.org:8080/#/c/12723/1/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12723/1/bin/bootstrap_system.sh@101 PS1, Line 101: export DEBIAN_FRONTEND=noninteractive This is not quite identical. Previously, we were setting this if we are not on an interactive terminal. Now we are always setting it. I think this is probably a good thing to use DEBIAN_FRONTEND=noninteractive always. I haven't run this recently, but I think maybe kerberos asks about certain settings. I think it is better for this script to avoid needing manual interaction beyond the first prompt. If we wanted to maintain the old way, we could check "if [[ ! -t 1 ]]" or whatnot. -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Wed, 13 Mar 2019 18:15:52 +0000 Gerrit-HasComments: Yes
