Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12723 )
Change subject: Move DEBIAN_FRONTEND=noninteractive variable to the ubuntu section of the script ...................................................................... Patch Set 1: > > (1 comment) > > > > Let me know what you think. If we go with always using > > DEBIAN_FRONTEND=noninteractive, then please note that in the > commit > > message. > > I can confirm that with the current package listing, on an ubuntu > 16.04 docker image the script behaves the same way before and after > this patch (no interactive prompts on apt-get). > > Personally, I prefer to export DEBIAN_FRONTEND=noninteractive in > the interactive terminal case since > a) we're already assuming that this script can be used by automated > scripts (ex. docker/entrypoint.sh) > b) we already perform system-wide configuration changes (postgres, > ntp, etc.) so presumably if in the future we add a dependency that > does require user interaction we can modify the configuration files > as we do now (or revisit this patch altogether :-). Sounds good, we'll use DEBIAN_FRONTEND=noninteractive always. Can you add one line to the commit message documenting this. Something like: "This also changes the behavior to always use DEBIAN_FRONTEND=noninteractive even for interactive terminals." With that change, I'm ready to +2. -- To view, visit http://gerrit.cloudera.org:8080/12723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifab2f56d3e119e4e73685c3cbd5249760ceb33ac Gerrit-Change-Number: 12723 Gerrit-PatchSet: 1 Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Thu, 14 Mar 2019 01:03:45 +0000 Gerrit-HasComments: No