Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 )
Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/12781/4/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/12781/4/shell/option_parser.py@77 PS4, Line 77: "append": > Do we need this fancy MultiOrderedDict here? Can't we just do Yeah because we parse the INI file using the parser. So the "options" variable is what comes from the parser and without customizing the parser, it will not handle duplicate keys. http://gerrit.cloudera.org:8080/#/c/12781/4/tests/shell/good_impalarc File tests/shell/good_impalarc: http://gerrit.cloudera.org:8080/#/c/12781/4/tests/shell/good_impalarc@4 PS4, Line 4: # TODO > Thanks, mind adding a TODO there with the jira reference? (so that others d Done -- To view, visit http://gerrit.cloudera.org:8080/12781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I824ca15b4e1064a391b13deef9cecd34c928ef73 Gerrit-Change-Number: 12781 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (395) Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Wed, 20 Mar 2019 22:15:36 +0000 Gerrit-HasComments: Yes
