Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12781 )
Change subject: IMPALA-8317: Add support for list type flags in Impala shell config file ...................................................................... Patch Set 8: Code-Review+2 (5 comments) http://gerrit.cloudera.org:8080/#/c/12781/4/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/12781/4/shell/option_parser.py@77 PS4, Line 77: "append": > Yeah because we parse the INI file using the parser. So the "options" varia Ah gotcha http://gerrit.cloudera.org:8080/#/c/12781/8/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/12781/8/shell/option_parser.py@78 PS8, Line 78: result[option] = value.split('\n') Kinda curious why you have to split on '\n' here again. Looks like you are already extend() ing in the __set_item__ override below, so I'd guess value here should be a list? Haven't dug into it but curious why. http://gerrit.cloudera.org:8080/#/c/12781/8/shell/option_parser.py@86 PS8, Line 86: class MultiOrderedDict(OrderedDict): Add a doc? (why this is used) http://gerrit.cloudera.org:8080/#/c/12781/8/tests/shell/good_impalarc File tests/shell/good_impalarc: http://gerrit.cloudera.org:8080/#/c/12781/8/tests/shell/good_impalarc@4 PS8, Line 4: # TODO: IMPALA-8330: Use flag names instead of dest names. nit: Move the comment to the opt_parser where we parse this? http://gerrit.cloudera.org:8080/#/c/12781/8/tests/shell/good_impalarc@9 PS8, Line 9: May be also add another keyval in the end (to make sure it gets parsed too)? -- To view, visit http://gerrit.cloudera.org:8080/12781 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I824ca15b4e1064a391b13deef9cecd34c928ef73 Gerrit-Change-Number: 12781 Gerrit-PatchSet: 8 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (395) Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 21 Mar 2019 00:22:40 +0000 Gerrit-HasComments: Yes
