Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 )
Change subject: Use 'wget http://169.254.169.254/' to determine if we're running in aws ...................................................................... Patch Set 5: (2 comments) I'm ready to +2 this. Just one more round of nitpicking. http://gerrit.cloudera.org:8080/#/c/12727/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12727/5//COMMIT_MSG@12 PS5, Line 12: `dmidecode -s bios-version` Nit: one more to switch to normal quotes http://gerrit.cloudera.org:8080/#/c/12727/5/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12727/5/bin/bootstrap_system.sh@239 PS5, Line 239: # EC2 nodes expose this IP address internally as a way to gather instance metadata. : # The assumption is that only AWS nodes do this Nit: Can we keep the original comment? i.e. # If on EC2, use Amazon's ntp servers # EC2 nodes expose this IP address internally as a way to gather instance metadata. # The assumption is that only AWS nodes do this -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 5 Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Fri, 22 Mar 2019 21:37:13 +0000 Gerrit-HasComments: Yes
