Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/12727 )
Change subject: Use `wget http://169.254.169.254/` to determine if we're running in aws ...................................................................... Patch Set 2: Code-Review+1 (1 comment) The check looks OK; see my suggestion about adding more explanation to where wget is called. http://gerrit.cloudera.org:8080/#/c/12727/2/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/12727/2/bin/bootstrap_system.sh@239 PS2, Line 239: If on EC2, use Amazon's ntp servers I'd suggest expanding the comment text here with a brief description about the URL and the purpose of the connection (verifying that the instance is running on EC2). Since this script is one of the first things a new Impala contributor encounters, they might get suspicious when they see it trying to connect to an unusual URL containing a numerical IP address -- not everyone is familiar with Amazon's metadata services. Repeating what's in the commit message is probably OK, it's just that the comment here stays associated with the wget line it describes. -- To view, visit http://gerrit.cloudera.org:8080/12727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iddb2574dbcb3f97cf697095d1777e51ce463b205 Gerrit-Change-Number: 12727 Gerrit-PatchSet: 2 Gerrit-Owner: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Mon, 18 Mar 2019 19:37:13 +0000 Gerrit-HasComments: Yes
