Andrew Sherman has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12823 )

Change subject: IMPALA-8330: Impala shell config file should use flag names
......................................................................


Patch Set 2:

(2 comments)

Looks good

http://gerrit.cloudera.org:8080/#/c/12823/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12823/2//COMMIT_MSG@10
PS2, Line 10: both short and long flag names instead of dest names because dest 
names
My life would be easier if you explained what a 'dest name' is here.


http://gerrit.cloudera.org:8080/#/c/12823/2//COMMIT_MSG@24
PS2, Line 24: ; Flags can be repeated.
Flags can be repeated. So if I have
query_options=DEFAULT_FILE_FORMAT=parquet
Q=DEFAULT_FILE_FORMAT=orc
will it all work OK?



--
To view, visit http://gerrit.cloudera.org:8080/12823
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9
Gerrit-Change-Number: 12823
Gerrit-PatchSet: 2
Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Mon, 25 Mar 2019 18:51:20 +0000
Gerrit-HasComments: Yes

Reply via email to