Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 )
Change subject: IMPALA-8330: Impala shell config file should use flag names ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/12823/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12823/2//COMMIT_MSG@10 PS2, Line 10: both short and long flag names instead of optparse's dest names > My life would be easier if you explained what a 'dest name' is here. Done http://gerrit.cloudera.org:8080/#/c/12823/2//COMMIT_MSG@24 PS2, Line 24: Q=DEFAULT_FILE_FORMAT=parquet > Flags can be repeated. So if I have Impala shell allows it, e.g. impala-shell.sh -query_option=DEFAULT=parquet -Q DEFAULT_FILE_FORMAT=orc The behavior is undefined, it can either be parquet or orc. -- To view, visit http://gerrit.cloudera.org:8080/12823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9 Gerrit-Change-Number: 12823 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 26 Mar 2019 14:40:35 +0000 Gerrit-HasComments: Yes
