Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 )
Change subject: IMPALA-8330: Impala shell config file should support flag names ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/12823/5/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/12823/5/shell/option_parser.py@132 PS5, Line 132: print >> sys.stderr, "WARNING: Option 'config_file' can be only set from shell." > I think you missed this, do we need this? Yes, in L144, we use upper case because for impala.query_options. Case sensitivity doesn't matter for query options. However for flag names, case sensitivity matters. -- To view, visit http://gerrit.cloudera.org:8080/12823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9 Gerrit-Change-Number: 12823 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@apache.org> Gerrit-Comment-Date: Fri, 29 Mar 2019 04:55:34 +0000 Gerrit-HasComments: Yes