Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/12823 )
Change subject: IMPALA-8330: Impala shell config file should support flag names ...................................................................... Patch Set 7: Code-Review+1 (2 comments) Carry +1 from Jim. http://gerrit.cloudera.org:8080/#/c/12823/6/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/12823/6/shell/option_parser.py@74 PS6, Line 74: # Allowing dest name for backward compatibility. > You might want to check that option1.dest is never equal to any option2._lo Done http://gerrit.cloudera.org:8080/#/c/12823/6/tests/shell/good_impalarc File tests/shell/good_impalarc: http://gerrit.cloudera.org:8080/#/c/12823/6/tests/shell/good_impalarc@4 PS6, Line 4: > nit: stray character? Done -- To view, visit http://gerrit.cloudera.org:8080/12823 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic43603c1b538af08fddcab1b2c1f6ad1af1a6cb9 Gerrit-Change-Number: 12823 Gerrit-PatchSet: 7 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@apache.org> Gerrit-Comment-Date: Thu, 28 Mar 2019 18:45:25 +0000 Gerrit-HasComments: Yes
