Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 )
Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly ...................................................................... Patch Set 2: Code-Review+1 (2 comments) Carrying Bharath's +1. http://gerrit.cloudera.org:8080/#/c/12954/1/be/src/util/system-state-info-test.cc File be/src/util/system-state-info-test.cc: http://gerrit.cloudera.org:8080/#/c/12954/1/be/src/util/system-state-info-test.cc@80 PS1, Line 80: face |bytes packets errs drop fifo frame compressed multicast|bytes packets errs drop fifo colls carrier compressed > nit: I think you could also dump these contents to some files and read them Do we currently do this in other tests? I like that they're are inlined here which prevents an additional indirection, but I agree that the long lines are not ideal. Let me know if you feel strongly about it, otherwise I'd keep them here. http://gerrit.cloudera.org:8080/#/c/12954/1/be/src/util/system-state-info.cc File be/src/util/system-state-info.cc: http://gerrit.cloudera.org:8080/#/c/12954/1/be/src/util/system-state-info.cc@172 PS1, Line 172: > nit: trace log something? Done -- To view, visit http://gerrit.cloudera.org:8080/12954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic804955d8e4269e787037a6dc68bef2d70382426 Gerrit-Change-Number: 12954 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Mon, 08 Apr 2019 20:00:19 +0000 Gerrit-HasComments: Yes
