Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12954 )
Change subject: IMPALA-8395: Parse older formats of /proc/net/dev correctly ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/12954/2/be/src/util/system-state-info.cc File be/src/util/system-state-info.cc: http://gerrit.cloudera.org:8080/#/c/12954/2/be/src/util/system-state-info.cc@168 PS2, Line 168: colon_idx = sp.find_first_of(':'); > Should this also check for the case of colon_idx == npos and skip ? Counters will come up empty in this case because substr() will return an empty StringPiece. Should I explain this in a comment? http://gerrit.cloudera.org:8080/#/c/12954/2/be/src/util/system-state-info.cc@170 PS2, Line 170: > I wonder if we should just skip if counters.values() < NUM_NET_VALUES ? Wil Done. I checked Centos6 and the manpage for proc lists the same fields. -- To view, visit http://gerrit.cloudera.org:8080/12954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic804955d8e4269e787037a6dc68bef2d70382426 Gerrit-Change-Number: 12954 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Mon, 08 Apr 2019 21:16:22 +0000 Gerrit-HasComments: Yes
