David Knupp has posted comments on this change. ( http://gerrit.cloudera.org:8080/12960 )
Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12960/2/tests/common/test_vector.py File tests/common/test_vector.py: http://gerrit.cloudera.org:8080/#/c/12960/2/tests/common/test_vector.py@79 PS2, Line 79: ValueError > Pedantic nit: ValueError is probably the wrong thing to raise here. From ht Actually -- wait. I don't know what I was misreading before. ValueError is exactly the right exception to raise. Sorry about that. That said, I still think a for/else loop is more idiomatic. -- To view, visit http://gerrit.cloudera.org:8080/12960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9673fe82bda5314aff6a51d1961759ff286fbf6f Gerrit-Change-Number: 12960 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Apr 2019 00:10:33 +0000 Gerrit-HasComments: Yes
