Hello David Knupp, Impala Public Jenkins, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12960 to look at the new patch set (#3). Change subject: IMPALA-8390: clean up test vectors in test_cancellation.py ...................................................................... IMPALA-8390: clean up test vectors in test_cancellation.py Due to changes to TestCancellation made in IMPALA-7205 that were not reflected in TestCancellationSerial and TestCancellationFullSort, test_cancel_insert has not been running at all and test_cancel_sort has been running with unintended parameters. This patch re-enables test_cancel_insert, while including a number of constraints on its parameters to keep test execution time reasonable. It also fixes an incorrect constraint on test_cancel_sort. The patch also makes some related improvements: - Removes an xfail on test_cancel_insert related to a bug that is fixed now. - When ImpalaTestVector.get_value() is called with a value name that does not actually exist in the vector, the result is a StopIteration exception. Due to python's questionable habit of using exceptions for flow control, StopIteration is frequently treated not as an error but as the normal end of iteration, which can result in unexpected behavior, eg. when pytest_generate_tests raises a StopIteration pytest just silently ignores it and drops the test case. This patch modifies get_value() to instead raise a ValueError in this situation. - When a test has no vectors generated for it, the name of the test is now included in the logged warning. Testing: - Ran full core and exhaustive runs and verified that the expected test cases are run for test_cancellation.py now Change-Id: I9673fe82bda5314aff6a51d1961759ff286fbf6f --- M tests/common/test_vector.py M tests/conftest.py M tests/query_test/test_cancellation.py 3 files changed, 26 insertions(+), 14 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/60/12960/3 -- To view, visit http://gerrit.cloudera.org:8080/12960 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I9673fe82bda5314aff6a51d1961759ff286fbf6f Gerrit-Change-Number: 12960 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <tmarsh...@cloudera.com>