Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 )
Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/12639/15/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/12639/15/tests/common/impala_cluster.py@272 PS15, Line 272: in-place of a list > Nit: "in-place sort of a list" Done http://gerrit.cloudera.org:8080/#/c/12639/15/tests/common/impala_cluster.py@420 PS15, Line 420: found > I think this should be "not found" Done http://gerrit.cloudera.org:8080/#/c/12639/15/tests/metadata/test_ddl.py File tests/metadata/test_ddl.py: http://gerrit.cloudera.org:8080/#/c/12639/15/tests/metadata/test_ddl.py@289 PS15, Line 289: # TODO: there is a hardcoded localhost in the test file. : # pytest.skip() > I think this can be removed Oops -- To view, visit http://gerrit.cloudera.org:8080/12639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee86cbd2c4631a014af1e8cef8e1cd523a812755 Gerrit-Change-Number: 12639 Gerrit-PatchSet: 15 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 12 Apr 2019 21:17:48 +0000 Gerrit-HasComments: Yes
