Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12639 )
Change subject: IMPALA-7995: part 1: fixes for e2e dockerised impala tests ...................................................................... Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/12639/17/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/12639/17/tests/common/impala_cluster.py@82 PS17, Line 82: def get_e2e_test_cluster(cls): > I'm a little confused about the necessity for this additional classmethod t So docker_network is derived from TEST_START_CLUSTER_ARGS, which is only used for end-to-end tests, not custom cluster tests or if you just run start-impala-cluster.py. ImpalaCluster is used in both of those cases, so it could be confusing to change behaviour based on a setting that doesn't affect all contexts. I'm not sure if this would create problems in our current jobs or workflows but it felt wrong to me, so I made it more explicit that we should try to detect settings for the end-to-end tests case. -- To view, visit http://gerrit.cloudera.org:8080/12639 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee86cbd2c4631a014af1e8cef8e1cd523a812755 Gerrit-Change-Number: 12639 Gerrit-PatchSet: 17 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Sat, 13 Apr 2019 00:28:50 +0000 Gerrit-HasComments: Yes
