Hector Acosta has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )
Change subject: Bump CDP_BUILD_NUMBER to 1013201 ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13002/3/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13002/3/bin/bootstrap_toolchain.py@508 PS3, Line 508: toolchain_host = os.environ.get("IMPALA_TOOLCHAIN_HOST") : cdh_build_number = os.environ.get("CDH_BUILD_NUMBER") nit: looks like it's safe to just use os.environ['IMPALA_TOOLCHAIN_HOST'] and os.environ['CDH_BUILD_NUMBER'] http://gerrit.cloudera.org:8080/#/c/13002/3/bin/bootstrap_toolchain.py@538 PS3, Line 538: use_cdp_hive = os.getenv("USE_CDP_HIVE") == "true" : if use_cdp_hive: Since use_cdp_hive is not used again: if os.environ.get('USE_CDP_HIVE') == true: http://gerrit.cloudera.org:8080/#/c/13002/3/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/13002/3/buildall.sh@540 PS3, Line 540: # extraneous #.. There's two more in this parragraph -- To view, visit http://gerrit.cloudera.org:8080/13002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada Gerrit-Change-Number: 13002 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Apr 2019 16:58:31 +0000 Gerrit-HasComments: Yes
