Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/13002 )
Change subject: Bump CDP_BUILD_NUMBER to 1013201 ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/13002/5/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: http://gerrit.cloudera.org:8080/#/c/13002/5/bin/bootstrap_toolchain.py@426 PS5, Line 426: present nit, Since CDP_COMPONENTS_HOME is a env variable, it is perhaps more correct to say make sure it is set than is present. http://gerrit.cloudera.org:8080/#/c/13002/5/impala-parent/pom.xml File impala-parent/pom.xml: http://gerrit.cloudera.org:8080/#/c/13002/5/impala-parent/pom.xml@114 PS5, Line 114: <id>impala.cdp.repo</id> I noticed, that adding such a repository generates a lot of warnings during build since maven tries to find the artificates in cdp repo first and then goes to cdh repo. While this is not a issue per say, it would be good to find a way to fix these warnings if possible or update the mvn-quiet.sh to ignore such warnings from being printed. -- To view, visit http://gerrit.cloudera.org:8080/13002 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18c7274085be4f87ecdaf0cd29a601715f594ada Gerrit-Change-Number: 13002 Gerrit-PatchSet: 5 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Hector Acosta <hector.aco...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Tue, 16 Apr 2019 17:47:38 +0000 Gerrit-HasComments: Yes
