Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13019 )
Change subject: IMPALA-8419 : Validate event processing related configurations ...................................................................... Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@73 PS7, Line 73: // flag to be set in the table/database parameters to disable event based metadata sync line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@20 PS7, Line 20: import static org.apache.impala.catalog.events.EventProcessorValidation.hasValidMetastoreConfigs; line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@21 PS7, Line 21: import static org.apache.impala.catalog.events.EventProcessorValidation.verifyParametersNotFiltered; line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@21 PS7, Line 21: import static org.apache.impala.catalog.events.EventProcessorValidation.validateMetastoreConfigs; line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@22 PS7, Line 22: import static org.apache.impala.catalog.events.EventProcessorValidation.validateMetastoreEventParameters; line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@71 PS7, Line 71: import org.apache.impala.catalog.events.EventProcessorValidation.MetastoreEventConfigsToValidate; line too long (97 > 90) http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1100 PS7, Line 1100: dbParams.put(MetastoreEventParameters.DISABLE_EVENT_HMS_SYNC_KEY.getKey(), dbFlag); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1114 PS7, Line 1114: MetastoreEventParameters.DISABLE_EVENT_HMS_SYNC_KEY.getKey(), tblTransition.second); line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13019/7/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@1621 PS7, Line 1621: alteredDb.putToParameters(MetastoreEventParameters.DISABLE_EVENT_HMS_SYNC_KEY.getKey(), line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94c2783e36287a65122003aa55d8075a806bc606 Gerrit-Change-Number: 13019 Gerrit-PatchSet: 7 Gerrit-Owner: Bharath Krishna <bhar...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Krishna <bhar...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Thu, 25 Apr 2019 20:22:31 +0000 Gerrit-HasComments: Yes
