Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13019 )
Change subject: IMPALA-8419 : Validate event processing related configurations ...................................................................... Patch Set 11: (7 comments) http://gerrit.cloudera.org:8080/#/c/13019/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/13019/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@20 PS11, Line 20: import static org.apache.impala.catalog.events.EventProcessorValidator.hasValidMetastoreConfigs; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13019/11/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@21 PS11, Line 21: import static org.apache.impala.catalog.events.EventProcessorValidator.verifyParametersNotFiltered; line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/13019/11/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/13019/11/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@21 PS11, Line 21: import static org.apache.impala.catalog.events.EventProcessorValidator.DEFAULT_METASTORE_CONFIG_VALUE; line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/13019/11/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@22 PS11, Line 22: import static org.apache.impala.catalog.events.EventProcessorValidator.METASTORE_PARAMETER_EXCLUDE_PATTERNS; line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/13019/11/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@23 PS11, Line 23: import static org.apache.impala.catalog.events.EventProcessorValidator.validateMetastoreConfigs; line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/13019/11/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@24 PS11, Line 24: import static org.apache.impala.catalog.events.EventProcessorValidator.validateMetastoreEventParameters; line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/13019/11/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@73 PS11, Line 73: import org.apache.impala.catalog.events.EventProcessorValidator.MetastoreEventConfigsToValidate; line too long (96 > 90) -- To view, visit http://gerrit.cloudera.org:8080/13019 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I94c2783e36287a65122003aa55d8075a806bc606 Gerrit-Change-Number: 13019 Gerrit-PatchSet: 11 Gerrit-Owner: Bharath Krishna <bhar...@cloudera.com> Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com> Gerrit-Reviewer: Bharath Krishna <bhar...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Mon, 29 Apr 2019 17:34:29 +0000 Gerrit-HasComments: Yes
