Fredy Wijaya has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13049 )

Change subject: IMPALA-8149 : Add support for alter_database events
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

I will give a chance for Bharath K take a look at it, too. I can promote to a 
+2 afterwards.

http://gerrit.cloudera.org:8080/#/c/13049/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
File 
fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java:

http://gerrit.cloudera.org:8080/#/c/13049/4/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@343
PS4, Line 343: est
> I was using clang tool do formatting, I guess it takes each argument as ind
I don't want to be a stickler. I'm cool with this.



--
To view, visit http://gerrit.cloudera.org:8080/13049
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf020e85cae04163bf32e31363eb4119d624640b
Gerrit-Change-Number: 13049
Gerrit-PatchSet: 5
Gerrit-Owner: Anonymous Coward <xiaom...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <xiaom...@cloudera.com>
Gerrit-Reviewer: Anurag Mantripragada <anu...@cloudera.com>
Gerrit-Reviewer: Bharath Krishna <bhar...@cloudera.com>
Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Apr 2019 23:59:12 +0000
Gerrit-HasComments: Yes

Reply via email to