Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/13242 )
Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13242/2/testdata/workloads/functional-query/queries/QueryTest/data-cache.test File testdata/workloads/functional-query/queries/QueryTest/data-cache.test: http://gerrit.cloudera.org:8080/#/c/13242/2/testdata/workloads/functional-query/queries/QueryTest/data-cache.test@41 PS2, Line 41: # Verifies that stale data from the cache is not used; nit: . instead of ; http://gerrit.cloudera.org:8080/#/c/13242/2/tests/custom_cluster/test_data_cache.py File tests/custom_cluster/test_data_cache.py: http://gerrit.cloudera.org:8080/#/c/13242/2/tests/custom_cluster/test_data_cache.py@39 PS2, Line 39: cache_force_single_shard Should we have a second test without that flag that just checks that the hit-rates are non-zero? -- To view, visit http://gerrit.cloudera.org:8080/13242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98d5b8fa1d3fb25682a64bffaf56d751a140e4c9 Gerrit-Change-Number: 13242 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Comment-Date: Sat, 04 May 2019 17:19:37 +0000 Gerrit-HasComments: Yes