Lars Volker has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13242 )

Change subject: IMPALA-8496: Fix flakiness of test_data_cache.py
......................................................................


Patch Set 3: Code-Review+2

(3 comments)

LGTM once the comments are fixed

http://gerrit.cloudera.org:8080/#/c/13242/3/tests/custom_cluster/test_data_cache.py
File tests/custom_cluster/test_data_cache.py:

http://gerrit.cloudera.org:8080/#/c/13242/3/tests/custom_cluster/test_data_cache.py@58
PS3, Line 58: reflected
...verifies that the cache hit count metrics are correct.


http://gerrit.cloudera.org:8080/#/c/13242/3/tests/custom_cluster/test_data_cache.py@59
PS3, Line 59: The number
"The exact number of bytes.."


http://gerrit.cloudera.org:8080/#/c/13242/3/tests/custom_cluster/test_data_cache.py@63
PS3, Line 63: "select count(distinct l_orderkey) from tpch_parquet.lineitem"
make the query a variable?



--
To view, visit http://gerrit.cloudera.org:8080/13242
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98d5b8fa1d3fb25682a64bffaf56d751a140e4c9
Gerrit-Change-Number: 13242
Gerrit-PatchSet: 3
Gerrit-Owner: Michael Ho <k...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Lars Volker <l...@cloudera.com>
Gerrit-Reviewer: Michael Ho <k...@cloudera.com>
Gerrit-Comment-Date: Sat, 04 May 2019 18:12:42 +0000
Gerrit-HasComments: Yes

Reply via email to