Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/13284 )
Change subject: IMPALA-8281: Misc Sentry decoupling clean up ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/13284/7/tests/authorization/test_sentry.py File tests/authorization/test_sentry.py: http://gerrit.cloudera.org:8080/#/c/13284/7/tests/authorization/test_sentry.py@93 PS7, Line 93: : ex = self.execute_query_expect_failure(self.client, "drop role non_role") : assert "" in str(ex) this is an odd behavior, we should document this in as comment for backward compatibility and also update the commit message -- To view, visit http://gerrit.cloudera.org:8080/13284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id24a00dd395e30e4c392f085893e9561da2ee539 Gerrit-Change-Number: 13284 Gerrit-PatchSet: 7 Gerrit-Owner: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Austin Nobis <ano...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 09 May 2019 22:31:40 +0000 Gerrit-HasComments: Yes
